[feat][client] PIP-446: Support Native OpenTelemetry Tracing in Pulsar Java Client #24873
+2,680
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
ready-to-test
area/client
type/feature
Member
|
@asafm Do you have a chance to review this PR? |
Contributor
|
@lhotari yes. This was the only comment I saw. |
Contributor
poorbarcode
approved these changes
Dec 16, 2025
Contributor
poorbarcode
left a comment
poorbarcode
left a comment
There was a problem hiding this comment.
I have one suggestion, it should be useful to determine client-side publish latency issue
- Should we add more events for producers, to let us to record more spans? Such as follows
users call send->cache message with message containerpublish message to broker->receive broker response
poorbarcode
approved these changes
Dec 16, 2025
|
|
||
| @Override | ||
| public void close() { | ||
| // No cleanup needed - spans are attached to messages |
Contributor
There was a problem hiding this comment.
Suggested change
| // No cleanup needed - spans are attached to messages | |
| // Producer will fail pending messages when it being closed, which will trigger the `onSendAcknowledgement` events |
poorbarcode
reviewed
Dec 16, 2025
| @Override | ||
| public Message beforeSend(Producer producer, Message message) { | ||
| // Initialize tracer from producer on first call | ||
| initializeIfNeeded(producer); |
Contributor
There was a problem hiding this comment.
Shouldn't we treat the first and last parts of a chunked message differently?
Contributor
There was a problem hiding this comment.
Please ignore this comment channel, because sendComplete already covered the case here: https://github.com/apache/pulsar/blob/v4.1.2/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L1372-L1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation of PIP-446
Documentation
docdoc-requireddoc-not-neededdoc-complete